Permissive int and float syntax highlighting#1230
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 16, 2026
Merged
Permissive int and float syntax highlighting#1230datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
datho7561
changed the title
datho7561
force-pushed
the
dont-syntax-highlight-timestamps
branch
from
2f7b9e3 to
02f4399
Compare
- Clean up the regex used to syntax highlight integers, booleans, and floats - Permit integers beginning with one or multiple `0`s - `<<` is syntax highlighted as an operator instead of having no scope (this means it changes in some themes, such as Monokai) Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
dont-syntax-highlight-timestamps
branch
from
02f4399 to
ddf5215
Compare
datho7561
changed the title
Contributor
Author
|
To try this out, switch to one of the default themes (eg. Dark (Visual Studio) or Dark 2026), then play around with this YAML file before and after: myList:
- 0001
- 0002
- 0003
- 0004
- 0005
- 08
- 09
- "pantaloons"
otherValue:
value: [0001, 0002, 00003, 0004, 0005, 0006, 0007, 0008, 0009, 08, 8, "pantpantpant"]
array:
- [001, 002, 03, 04, 05, 06, 07, 08, 09]
- 2010-06-15T00:00:00
prop:
- 1
- .5
- 1.5
- 1..5
- ..5
- ..
- .
- 1.5.1
prop2: [1, .5, 1.5, 1..5, ..5, .., .]
prop3: null
prop4:
- 55:55:55
- 55:55:55.99
prop5: <<
prop6:
- <<
prop7: [<<, 1.2, 1.3, 1.8, 1.9] |
Contributor
Author
|
Root cause of test failures: microsoft/vscode-test#332 |
shin19991207
approved these changes
Apr 16, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
Looks good to me and works well from my manual testing. Thanks, David!
This was
linked to
issues
Apr 16, 2026
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
0sBroke syntax highlighting offixed<<<<is syntax highlighted as an operator instead of having no scope (this means it changes in some themes, such as Monokai)What issues does this PR fix or reference?
#1190, #1225
Is it tested? How?
Manually